better error reporting when semanticdb-scalac is not found #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
changed the title
bjaglin
force-pushed
the
actionnable-error
branch
from
8ef11e7
to
f2d989b
Compare
semanticdb-scalac is now only published for the 4 latest patch releases for each minor scala version, see scalameta/scalameta#3250
bjaglin
force-pushed
the
actionnable-error
branch
from
f2d989b
to
8b5275a
Compare
bjaglin
force-pushed
the
actionnable-error
branch
from
8b5275a
to
4ced96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows scalacenter/scalafix#1857
Lead-up
Since scalameta/scalameta#3250, semanticdb-scalac is no longer published for all patch releases of Scala 2.13 and most patch releases of Scala 2.12, but only the 4 latest for each.
Impact
scalafixEnableis able to lookup a suitable scalameta version as of #292, but "permanent" sbt-scalafix / Scala 2.x users, leveraging sbt's SemanticdbPlugin viaper the documentation, are at the risk of getting errors if they run an old patch scala version, while it was working fine until now (up to Scalafix 0.11.0 / scalameta 4.7.8).
That means that this effectively a breaking change, but as the likelihood of a user setting up the latest scalafix version against a project that is running a very outdated scala version is minimal, this PR simply improves error reporting and we won't be bumping the minor version to highlight the change.